[ALS-6265] Add any record of multi support to time series processor #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramari16
reviewed
Jun 14, 2024
| @@ -94,6 +95,7 @@ private void exportTimeData(Query query, AsyncResult result, TreeSet<Integer> id | |||
| //get a list of all fields mentioned in the query; export all data associated with any included field | |||
| List<String> pathList = new LinkedList<String>(); | |||
| pathList.addAll(query.getAnyRecordOf()); | |||
| pathList.addAll(query.getAnyRecordOfMulti().stream().flatMap(Collection::stream).collect(Collectors.toList())); | |||
There was a problem hiding this comment.
This is going to exponentially increase the data being returned in some cases. Is performance a worry here? And do people really expect to get all of this data back?
There was a problem hiding this comment.
I mean, as it stands, when you request data from an any record of multi query, you get nothing back. We can deal with slow exports in GIC; as long as HPDS doesn't run oom, it doesn't really matter.
srpiatt
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.